Dangling pointer bugfix for upstream check module while update the upstream via dyups #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dangling pointer access, while
ngx_http_dyups_module
andngx_http_upstream_check_module
are used together.Because
dyups
has its ownsrv_conf
and it will be freed when the upstream is deleted,but upstream check timer will still be exists and access its srv conf via
peer->conf
.To avoid dangling pointer access, we should delete the dynamic peer while its upstream is deleting.