Limit proxy/memcached/fastcgi/scgi/uwsgi upstream tries times #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proxy_next_upstream retry times. This directive can work in main/server/http/location config, and is disabled by default(default behavior is to try ALL upstreams). Partial code is forked from patch: https://gist.github.com/shai-d/5446961.
| @@ -437,6 +437,13 @@ static char *ngx_http_fastcgi_lowat_check(ngx_conf_t *cf, void *post, | |||
| offsetof(ngx_http_fastcgi_loc_conf_t, upstream.next_upstream), | |||
| &ngx_http_fastcgi_next_upstream_masks }, | |||
|
|
|||
| { ngx_string("fastcgi_upstream_tries"), | |||
There was a problem hiding this comment.
Is the directive name fastcgi_next_tries better? It matches with the directive fastcgi_next_upstream.
There was a problem hiding this comment.
yes, xxx_next_tries matches xxx_next_upstream better. however, i think maybe xxx_upstream_tries presents the directive function better. xxx_next_tries may confuse users: when tries number is 1, there is no "next_tries", this is 1 upstream_tries.
|
Thank you for the contribution. Could you add some test cases for this patch? See this case as an example: https://github.com/alibaba/tengine/pull/318/files#diff-2 |
|
thank you. will do that in coming vacation ;) |
|
Looks good to me. |
cfsego
pushed a commit
that referenced
this pull request
Oct 10, 2013
Limit proxy/memcached/fastcgi/scgi/uwsgi upstream tries times
|
能否为next_retries提供一个md文档，介绍模块的使用。提交到tengine的docs/modules下面 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proxy/memcached/fastcgi/scgi/uwsgi_upstream_tries directives which can limit proxy/memcached/fastcgi/scgi/uwsgi upstream tries times. These directives can work in main/server/location configs, and are disabled by default(default behavior is to try ALL upstreams). Partial code is
forked from patch: https://gist.github.com/shai-d/5446961.