ngx_debug_pool: provide access to information of memory usage #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
force-pushed
the
ngx_debug_pool
branch
6 times, most recently
from
78f978b
to
f067821
Compare
| ngx_uint_t i; | ||
| ngx_pool_stat_t *stat; | ||
|
|
||
| #define NGX_POOL_PID_SIZE (NGX_TIME_T_LEN + sizeof("pid:\n") - 1) /* sizeof pid_t equals time_t */ |
There was a problem hiding this comment.
这里不把1次性的宏写到计算size和sprintf里面，是使得下面的代码更加紧凑。
这里没必要用const，这里所有的宏都是为了简化下面代码(计算size和sprintf)和方便统一修改格式。
There was a problem hiding this comment.
另外没有把这些宏移到头部，是因为这些宏只在这个函数内起作用，并且放在size计算和sprintf逻辑之前也方便查看和改写
chobits
force-pushed
the
ngx_debug_pool
branch
from
f067821
to
588f1f7
Compare
|
能够把ngx_palloc.*的两个文件全部移入模块目录，通过在config中的变换操作使编译使用我们提供的代码。
|
chobits
force-pushed
the
ngx_debug_pool
branch
from
588f1f7
to
866ee9e
Compare
|
@cfsego |
|
LGTM |
cfsego
added a commit
that referenced
this pull request
Nov 25, 2015
ngx_debug_pool: provide access to information of memory usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A standalone module for nginx is here.