Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource alicloud oss bucket objects #692

Merged
merged 5 commits into from
Sep 21, 2018
Merged

Datasource alicloud oss bucket objects #692

merged 5 commits into from
Sep 21, 2018

Conversation

marcplouhinec
Copy link
Contributor

Add a new data source alicloud_oss_bucket_objects.

Test results:

GOROOT=/usr/local/go #gosetup
GOPATH=/Users/marcplouhinec/go #gosetup
/usr/local/go/bin/go test -c -i -v -sweep=cn-beijing -o /private/var/folders/v1/jvjz3zmn64q0j34yc9m9n4w00000gn/T/___Test_in_Beijing__non_verbose_ github.com/alibaba/terraform-provider/alicloud #gosetup
github.com/alibaba/terraform-provider/alicloud
github.com/alibaba/terraform-provider/alicloud (testmain)
/usr/local/go/bin/go tool test2json -t /private/var/folders/v1/jvjz3zmn64q0j34yc9m9n4w00000gn/T/___Test_in_Beijing__non_verbose_ -test.v -test.run ^TestAccAlicloudOssBucketObjectsDataSource_ #gosetup
=== RUN   TestAccAlicloudOssBucketObjectsDataSource_basic
--- PASS: TestAccAlicloudOssBucketObjectsDataSource_basic (8.85s)
=== RUN   TestAccAlicloudOssBucketObjectsDataSource_filterByPrefix
--- PASS: TestAccAlicloudOssBucketObjectsDataSource_filterByPrefix (6.47s)
PASS

xiaozhu36
xiaozhu36 requested changes Sep 21, 2018
View reviewed changes
alicloud/data_source_alicloud_oss_bucket_objects.go Outdated
},

// Computed values
"bucket_objects": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just use objects is ok and there is no need bucket_objects.

alicloud/resource_alicloud_oss_bucket_object.go
if err != nil {
return nil, fmt.Errorf("expires format must respect the RFC1123 standard (current value: %s)", expires)
}
options = append(options, oss.Expires(expiresTime))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested in TestAccAlicloudOssBucketObjectsDataSource_basic

@xiaozhu36 xiaozhu36 merged commit 9c878ac into alibaba:master Sep 21, 2018
@marcplouhinec marcplouhinec deleted the datasource_alicloud_oss_bucket_objects branch October 22, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhu36 xiaozhu36 xiaozhu36 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcplouhinec @xiaozhu36