Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource alicloud_fc_triggers. #695

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Datasource alicloud_fc_triggers. #695

merged 2 commits into from
Sep 21, 2018

Conversation

marcplouhinec
Copy link
Contributor

Create the datasource alicloud_fc_triggers.

Test results:

GOROOT=/usr/local/go #gosetup
GOPATH=/Users/marcplouhinec/go #gosetup
/usr/local/go/bin/go test -c -i -v -sweep=eu-central-1 -o /private/var/folders/v1/jvjz3zmn64q0j34yc9m9n4w00000gn/T/___Test_in_Frankfurt__non_verbose_ github.com/alibaba/terraform-provider/alicloud #gosetup
github.com/alibaba/terraform-provider/alicloud
github.com/alibaba/terraform-provider/alicloud (testmain)
/usr/local/go/bin/go tool test2json -t /private/var/folders/v1/jvjz3zmn64q0j34yc9m9n4w00000gn/T/___Test_in_Frankfurt__non_verbose_ -test.v -test.run ^TestAccAlicloudFcTriggersDataSource_basic$ #gosetup
=== RUN   TestAccAlicloudFcTriggersDataSource_basic
--- PASS: TestAccAlicloudFcTriggersDataSource_basic (92.30s)
PASS

xiaozhu36
xiaozhu36 requested changes Sep 21, 2018
View reviewed changes
alicloud/data_source_alicloud_fc_triggers.go Outdated
Computed: true,
},
"raw_trigger_config": {
Type: schema.TypeString,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is called raw_trigger_config and I think config is ok.

alicloud/data_source_alicloud_fc_triggers.go Outdated
Type: schema.TypeString,
Computed: true,
},
"trigger_type": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think type is better than trigger_type

@xiaozhu36 xiaozhu36 merged commit 8fd5cf0 into alibaba:master Sep 21, 2018
@marcplouhinec marcplouhinec deleted the datasource_alicloud_fc_triggers branch October 22, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhu36 xiaozhu36 xiaozhu36 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcplouhinec @xiaozhu36