Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add bytecode version verification plugin #590

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

wuwen5
Copy link
Collaborator

@wuwen5 wuwen5 commented Dec 20, 2023

增加字节码版本校验,便于在升级外部依赖时校验与本项目构建版本是否兼容.

例如 当我们试图升级javassist-3.30.1-GA时,能快速检测出它的构建版本为jdk11

[INFO] --- maven-enforcer-plugin:3.4.1:enforce (enforce-maven) @ ttl-agent ---
[INFO] Adding ignore: module-info
[INFO] Restricted to JDK 8 yet org.javassist:javassist:jar:3.30.1-GA:compile contains javassist/ByteArrayClassPath$BytecodeURLConnection.class targeted to JDK 11
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] ttl3-parent ........................................ SUCCESS [  0.431 s]
[INFO] TransmittableThreadLocal(TTL) ...................... SUCCESS [  8.068 s]
[INFO] TransmittableThreadLocal(TTL) Agent ................ FAILURE [  0.024 s]
[INFO] TransmittableThreadLocal(TTL) kotlin support ....... SKIPPED
[INFO] TransmittableThreadLocal(TTL) v2 compatible ........ SKIPPED
[INFO] ttl-bom ............................................ SKIPPED
[INFO] vertx4-ttl-integration ............................. SKIPPED
[INFO] vertx3-ttl-integration ............................. SKIPPED
[INFO] sample-ttl-agent-extension-transformlet ............ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.712 s
[INFO] Finished at: 2023-12-20T10:15:29+08:00
[INFO] Final Memory: 48M/901M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-maven) on project ttl-agent:
[ERROR] Rule 0: org.codehaus.mojo.extraenforcer.dependencies.EnforceBytecodeVersion failed with message:
[ERROR] Found Banned Dependency: org.javassist:javassist:jar:3.30.1-GA
[ERROR] Use 'mvn dependency:tree' to locate the source of the banned dependencies.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ec33e) 41.54% compared to head (e8cfe42) 41.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #590   +/-   ##
=========================================
  Coverage     41.54%   41.54%           
  Complexity      293      293           
=========================================
  Files            47       47           
  Lines          1733     1733           
  Branches        237      237           
=========================================
  Hits            720      720           
  Misses          987      987           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oldratlee
Copy link
Member

COOOL 🚀

@oldratlee oldratlee merged commit a8b0ead into alibaba:master Dec 21, 2023
12 checks passed
@oldratlee oldratlee self-assigned this Dec 21, 2023
oldratlee added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Feb 22, 2024
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
oldratlee added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Jerry Lee <oldratlee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants