* [android] allow rewrite component

alibaba · Jun 23, 2016 · 2d5284b · 2d5284b
1 parent c3e4d0e
commit 2d5284b
Showing 1 changed file with 9 additions and 18 deletions.
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java b/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java
@@ -237,7 +237,15 @@ public static boolean registerComponent(String type, Class<? extends WXComponent
     return registerNativeComponent(type, clazz) && registerJSComponent(componentInfo);
   }
 
-  public static boolean registerNativeComponent(String type, Class<? extends WXComponent> clazz) throws WXException {
+  private static boolean registerNativeComponent(String type, Class<? extends WXComponent> clazz) throws WXException {
+    if (type == null) {
+      if (WXEnvironment.isApkDebugable()) {
+        throw new WXException("Component name required." );
+      } else {
+        WXLogUtils.e("Component name required." + type);
+        return false;
+      }
+    }
     //same component class for different name
     ComponentHolder holder;
     if(sClassTypeMap.get(clazz.getName()) == null){
@@ -265,23 +273,6 @@ public static boolean registerComponent(Map<String, String> componentInfo, Class
     }
 
     String type = componentInfo.get("type");
-    if (type == null) {
-      if (WXEnvironment.isApkDebugable()) {
-        throw new WXException("Exist duplicate component:" + type);
-      } else {
-        WXLogUtils.e("WXComponentRegistry Exist duplicate component: " + type);
-        return false;
-      }
-    }
-    if (sTypeComponentMap.containsKey(type)) {
-      if (WXEnvironment.isApkDebugable()) {
-        throw new WXException("Exist duplicate component:" + type);
-      } else {
-        WXLogUtils.e("WXComponentRegistry Exist duplicate component: " + type);
-        return false;
-      }
-    }
-
     return registerNativeComponent(type, clazz) && registerJSComponent(componentInfo);
   }