Skip to content

Commit

Permalink
* [jsfm] fix transformer version
Browse files Browse the repository at this point in the history
  • Loading branch information
terrykingcha committed Apr 27, 2016
1 parent fdf51b1 commit 9f21bcc
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 4 deletions.
16 changes: 15 additions & 1 deletion src/js-framework/lib/__test__/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ describe('test input and output', function () {
delete allDocs[name]
})

it('a wrong transformer version', () => {
it('a less wrong transformer version', () => {
var name = 'transformer2'
var inputCode = readInput(name)
var outputCode = readOutput(name)
Expand All @@ -730,4 +730,18 @@ describe('test input and output', function () {
framework.destroyInstance(name)
delete allDocs[name]
})


it('a bigger wrong transformer version', () => {
var name = 'transformer3'
var inputCode = readInput(name)
var outputCode = readOutput(name)
var doc = new Document(name)
allDocs[name] = doc

var result = framework.createInstance(name, inputCode)
expect(result).to.be.an.instanceof(Error)
framework.destroyInstance(name)
delete allDocs[name]
})
})
10 changes: 8 additions & 2 deletions src/js-framework/lib/app/__test__/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ describe('parsing a bundle file', () => {
const ready = sinon.spy()

before(() => {
global.needTransformerVersion = '~0.1'
global.needTransformerVersion = '>=0.1 <1.0'
app.define('@weex-component/main', (require, exports, module) => {
module.exports = {
template: componentTemplate,
Expand Down Expand Up @@ -238,12 +238,18 @@ describe('parsing a bundle file', () => {
expect(task2.args[2]).to.be.equal(-1)
})

it('with a wrong transformer version', () => {
it('with a less wrong transformer version', () => {
const result = app.bootstrap(
'@weex-component/main', {transformerVersion: '0.0.1'})
expect(result).instanceof(Error)
})

it('with a bigger wrong transformer version', () => {
const result = app.bootstrap(
'@weex-component/main', {transformerVersion: '9.9.9'})
expect(result).instanceof(Error)
})

})
})

Expand Down
2 changes: 1 addition & 1 deletion src/js-framework/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@
"webpack": "~1.12.12"
},
"optionalDependencies": {
"weex-transformer": "~0.3"
"weex-transformer": ">=0.1.7 <0.4"
}
}

0 comments on commit 9f21bcc

Please sign in to comment.