Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc add #1199

Closed
wants to merge 2 commits into from
Closed

Doc add #1199

wants to merge 2 commits into from

Conversation

jiuyuegui
Copy link
Contributor

add navigator translation

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ ���君
❌ 之君


���君, 之君 seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@vczero
Copy link
Member

vczero commented Sep 14, 2016

Hi, @jiuyuegui
这个翻译很棒,但是有两件事需要做一下:

  1. Storage weexteam/article#78 这篇文章有些地方需要处理:
    1) 文章中Storage翻译成“缓存”有些不合理, 可以修改成“本地存储”
    2) “...或者更新已经存在的键” 这句翻译有误,应该是“该方法可以通过键值对的形式将数据存储到本地。同时可以通过该方法,更新已有的数据。”
    3) 文中“键名”最好是“键值”

2.需要签署 licence/cla(Contributor License Agreement)协议才能进行合并。

因此,我需要等你这两个修改完成后才能合并。

有问题,随时 at 我,多谢,:)

@vczero vczero mentioned this pull request Sep 14, 2016
@Jinjiang
Copy link
Contributor

@jiuyuegui Because a long time CLA not signed. We commit #1227 and merged instead.
But always thanks.

@Jinjiang Jinjiang closed this Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants