Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsfm] Fix the rollup tree shaking accuracy #1560

Merged

Conversation

Hanks10100
Copy link
Member

Rollup mistakenly eliminated few functions by tree shaking. Use a little tricks to make it works well.

  • Remove the usage of this in downgrade, just call the method directly.
  • Import promise hack (for iOS) before its polyfill.

@Jinjiang Jinjiang merged commit f7447e3 into alibaba:jsfm-feature-0.17 Nov 8, 2016
@Jinjiang Jinjiang deleted the jsfm-feature-fix-rollup branch November 8, 2016 19:37
@Jinjiang
Copy link
Contributor

Jinjiang commented Nov 8, 2016

It's better to separate the three changes nothing related with each other into different PRs next time.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants