Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsfm] support component methods in another way #1604

Merged
merged 3 commits into from
Nov 22, 2016
Merged

[jsfm] support component methods in another way #1604

merged 3 commits into from
Nov 22, 2016

Conversation

Jinjiang
Copy link
Contributor

@Jinjiang Jinjiang commented Nov 8, 2016

No description provided.

@MrRaindrop
Copy link
Member

In current html5 render, the callComponentMethod method in runtime/listener.js for virtual dom should be reimplemented in the dom/componentManager.js, because the document's listener is replaced by it. @Jinjiang @fkysly @Hanks10100

@Hanks10100
Copy link
Member

@MrRaindrop Thanks for your reminder, I will add this feature in html5-feature-0.5.

@Hanks10100 Hanks10100 mentioned this pull request Nov 9, 2016
Closed
@Hanks10100 Hanks10100 mentioned this pull request Nov 18, 2016
Merged
@Hanks10100
Copy link
Member

It can be merged, and the modification of vm.$el should be reverted. #1665

@Hanks10100 Hanks10100 merged commit 9773f7d into alibaba:jsfm-feature-0.17 Nov 22, 2016
@Jinjiang Jinjiang deleted the jsfm-feature-component-methods branch December 9, 2016 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fkysly fkysly

@Hanks10100 Hanks10100

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jinjiang @MrRaindrop @Hanks10100 @fkysly