Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small optimizations for XQUIC #410

Merged
merged 2 commits into from Apr 24, 2024

Conversation

Ya-Pasha-364shy
Copy link
Contributor

@Ya-Pasha-364shy Ya-Pasha-364shy commented Apr 12, 2024

Hello everyone. Here I have prepared a small request containing some optimizations for the xquic implementation, which, it seems to me, have a right to exist. I will be glad to receive feedback.

  • Best regards, Pavel

src/transport/scheduler/xqc_scheduler_backup.c Outdated Show resolved Hide resolved
src/transport/scheduler/xqc_scheduler_backup.c Outdated Show resolved Hide resolved
src/transport/xqc_engine.c Outdated Show resolved Hide resolved
src/transport/xqc_multipath.h Outdated Show resolved Hide resolved
src/transport/xqc_engine.c Outdated Show resolved Hide resolved
src/transport/scheduler/xqc_scheduler_minrtt.c Outdated Show resolved Hide resolved
@Ya-Pasha-364shy
Copy link
Contributor Author

Hello !
I tried to correct all the comments, please look at it in your free time

src/transport/xqc_engine.c Outdated Show resolved Hide resolved
src/transport/scheduler/xqc_scheduler_minrtt.c Outdated Show resolved Hide resolved
src/transport/scheduler/xqc_scheduler_minrtt.c Outdated Show resolved Hide resolved
[-] removed unnecessary "memset" calls after "calloc"
[~] changed using of "xqc_send_ctl_get_srtt"
src/transport/xqc_engine.c Outdated Show resolved Hide resolved
[-] removed unnecessary "memset" calls after "calloc"
tests/test_client.c Show resolved Hide resolved
Copy link
Collaborator

@yangfurong yangfurong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangfurong yangfurong merged commit 13d31bd into alibaba:main Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants