[!] fix handle Retire Prior To error when NEW_CONNECTION_ID arrives and retire all the previous CIDs #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and fin separately.
…nd retire all the previous CIDs
* 'main' of ssh://github.com/Kulsk/xquic: [!] fix interop multiplexing testcase error when hq stream send content and fin separately. (alibaba#420)
Yanmei-Liu
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if peer issues a NEW_CONNECTION_ID frame and retire all the previous CIDs with Retire Prior To field, XQUIC will consider there is not enough CID and fails to handle this case as XQUIC don't insert the new CID in its dcid_set before handle Retire Prior To field.
Insert CID before handling Retire Prior To field, and allow temporary exceed of local CID limit.