Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

Streamers auto registration #6

Merged
merged 5 commits into from Apr 9, 2019

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Mar 29, 2019

No description provided.

@sbinet sbinet requested a review from aphecetche March 29, 2019 14:12
@sbinet
Copy link
Contributor Author

sbinet commented Apr 2, 2019

ping @aphecetche
are you ok with these cosmetic renames + consolidation?

@aphecetche
Copy link
Collaborator

@sbinet won't have time to properly review this until next week, but if you need to merge it, please go ahead.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 2, 2019

this can wait next week.

@aphecetche
Copy link
Collaborator

@sbinet just to be sure I understand what you did : you "integrated" the streamers definition back in the files that define the objects, i.e. merging in a same file the generated code and the hand-written one, is that right ?

@sbinet
Copy link
Contributor Author

sbinet commented Apr 9, 2019

yes.

usually I agree it'd be better to leave automatically generated files and handwritten files separated (for convenience and for git history) but I don't expect the definition of these C++ classes to see much churn at this point in time.

@aphecetche
Copy link
Collaborator

Yes, but you also assume that the generated parts won't change much either ;-)
But ok, those are probably reasonable assumptions, so let's merge this.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 9, 2019

Yes, but you also assume that the generated parts won't change much either ;-)

true. the generated parts will probably change to support generic reading/writing for all streamers.
once I finally get to finalize that part :)

@sbinet sbinet merged commit 12b7240 into alice-go:master Apr 9, 2019
@sbinet sbinet deleted the streamers-auto-registration branch April 9, 2019 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants