Address draft comments in review

.golangci.yaml

@@ -6,6 +6,7 @@ run:
 linters:
   enable:
     - errcheck
+  # Disabling linters until we get them fixed up.
   disable:
     - gosimple
     - govet

cmd/testutils/layer1_tx_spammer/main.go

@@ -283,14 +283,10 @@ func main() {
 	defer watcher.Close()
 	if isUsingTestAccounts {
 		// this function will block for finality delay blocks
-		err := tests.FundAccounts(eth, watcher, logger)
-		if err != nil {
+		if err := tests.FundAccounts(eth, watcher, logger); err != nil {
 			panic("Unable to fund test accounts")
 		}
 		tests.SetNextBlockBaseFee(eth.GetEndpoint(), 100_000_000_000)
-		if err != nil {
-			panic("Unable to fund set next block base fee")
-		}
 	}
 
 	// spawn num of Workers

consensus/objs/rs.go

@@ -465,10 +465,8 @@ func (b *RoundState) TrackExternalConflicts(v *Proposal) {
 		return
 	}
 	// is current
-	_, err := b.checkStaleAndConflict(v, false)
-	if err != nil {
-		return
-	}
+	// nolint:errcheck // review error checking for RoundState
+	b.checkStaleAndConflict(v, false)
 }
 
 func (b *RoundState) SetRCert(rc *RCert) error {

dynamics/db_test.go

@@ -81,7 +81,7 @@ func TestGetSetNode(t *testing.T) {
 	db := initializeDB()
 
 	node := &Node{}
-	_ = db.rawDB.Update(func(txn *badger.Txn) error {
+	err := db.rawDB.Update(func(txn *badger.Txn) error {
 		err := db.SetNode(txn, node)
 		if err == nil {
 			t.Fatal("Should have raised error (1)")
@@ -120,6 +120,9 @@ func TestGetSetNode(t *testing.T) {
 		}
 		return nil
 	})
+	if err != nil {
+		t.Fatal("unable to complete test")
+	}
 }
 
 func TestGetSetLinkedList(t *testing.T) {

layer1/executor/task_manager.go

@@ -122,10 +122,7 @@ func (tm *TaskManager) eventLoop() {
 
 		case taskRequest, ok := <-tm.requestChan:
 			if !ok {
-				err := tm.onError(ErrReceivedRequestClosedChan)
-				if err != nil {
-					tm.logger.Warn("task manager is closing")
-				}
+				_ = tm.onError(ErrReceivedRequestClosedChan)
 				return
 			}
 			if taskRequest.response == nil {