Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage tool fix, all regular tests passes, coverage test conditions… #10

Merged
2 commits merged into from
Jun 23, 2022

Conversation

z-j-lin
Copy link
Contributor

@z-j-lin z-j-lin commented Jun 23, 2022

… need fixing for running solidity coverage

Scope

What is changing with this PR?
working coverage tool

Why?

for solidity test coverage metrics

Todos

fix test setups for coverage, as of now due to the instrumentation the default account runs out of test eth on the hardhat network before tests are done. add checks in tests to rotate balances or any other way to add test eth to admin account.

  • ???

@ghost ghost self-requested a review June 23, 2022 18:48
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghost ghost merged commit a5f9bf1 into alicenet:main Jun 23, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant