Remaining solidity native errors #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
===========================================
+ Coverage 18.17% 48.49% +30.32%
===========================================
Files 247 281 +34
Lines 26470 40912 +14442
Branches 362 0 -362
===========================================
+ Hits 4812 19842 +15030
+ Misses 21459 18768 -2691
- Partials 199 2302 +2103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
keirongulrajani
force-pushed
the
solidity-native-errors
branch
from
50d0d77
to
dc359c2
Compare
vtleonardo
reviewed
Jul 29, 2022
vtleonardo
reviewed
Jul 29, 2022
vtleonardo
reviewed
Jul 29, 2022
keirongulrajani
force-pushed
the
solidity-native-errors
branch
2 times, most recently
from
163b476
to
fd3db78
Compare
Admin AlicenetFactoryBase Base64 BClaimsParserLib
Removed redundant/clashing libs
Move from custom chai assertion to hardhat assertion
Removed unused chai helpers
z-j-lin
reviewed
Aug 3, 2022
vtleonardo
reviewed
Aug 3, 2022
vtleonardo
reviewed
Aug 3, 2022
vtleonardo
reviewed
Aug 3, 2022
vtleonardo
reviewed
Aug 3, 2022
bridge/contracts/libraries/parsers/MerkleProofParserLibrary.sol
Outdated
Show resolved
Hide resolved
vtleonardo
reviewed
Aug 3, 2022
vtleonardo
reviewed
Aug 3, 2022
vtleonardo
approved these changes
Aug 4, 2022
|
LGTM. All contracts and unit tests reviewed. Integration tests passed:
|
ghost
added
the
nelsonhp
approved these changes
Aug 10, 2022
| ) | ||
| ) | ||
| ); | ||
| if (caller_ != ownerOf(tokenID_)) { |
There was a problem hiding this comment.
Not concern of this PR as it is out of scope but this line MUST be covered. Noting for ticket creation.
| if (caller_ != ownerOf(tokenID_)) { | ||
| revert StakingNFTErrors.CallerNotTokenOwner(msg.sender); | ||
| } | ||
| if (lockDuration_ > _MAX_GOVERNANCE_LOCK) { |
There was a problem hiding this comment.
Not concern of this PR as it is out of scope but this line MUST be covered. Noting for ticket creation.
z-j-lin
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Solidity native errors for:
Updated immutable auth to auto generate solidity native errors for generated immutable contracts
Installed updated hardhat lib for asserting new custom errors in tests
updated bindings
Why?
MP-591
Todos
If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?