-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AToken/BToken to ALCA/ALCB #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed BToken > ALCB Refactored interfaces for a/b tokens to staking/utility
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 48.58% 50.73% +2.15%
==========================================
Files 281 281
Lines 40900 40900
==========================================
+ Hits 19871 20751 +880
+ Misses 18736 17764 -972
- Partials 2293 2385 +92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vtleonardo
reviewed
Aug 11, 2022
vtleonardo
requested changes
Aug 11, 2022
removed duplicate struct definition
1baee6b
to
61b62c9
Compare
vtleonardo
reviewed
Aug 15, 2022
vtleonardo
reviewed
Aug 15, 2022
Made sure token minter/burner implements appropriate interfaces
nelsonhp
approved these changes
Aug 19, 2022
nelsonhp
approved these changes
Aug 19, 2022
vtleonardo
approved these changes
Aug 19, 2022
vtleonardo
referenced
this pull request
in vtleonardo/alicenet
Sep 26, 2022
* added npm install * changed npm install to npm ci in main.sh init script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Why?
MP-728
Todos
If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?