Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AToken/BToken to ALCA/ALCB #156

Merged
merged 9 commits into from
Aug 19, 2022

Conversation

keirongulrajani
Copy link
Contributor

Scope

  • Renamed AToken > ALCA
  • Renamed BToken > ALCB
  • Refactored interfaces for a/b tokens to staking/utility for improved clarity/maintenance

Why?

MP-728

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

Renamed BToken > ALCB
Refactored interfaces for a/b tokens to staking/utility
@keirongulrajani keirongulrajani requested a review from a team as a code owner August 11, 2022 12:11
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #156 (29bbaaa) into main (a877bc0) will increase coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   48.58%   50.73%   +2.15%     
==========================================
  Files         281      281              
  Lines       40900    40900              
==========================================
+ Hits        19871    20751     +880     
+ Misses      18736    17764     -972     
- Partials     2293     2385      +92     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (+3.90%) ⬆️
utils/shared.go 58.62% <0.00%> (+5.17%) ⬆️
constants/dbprefix/layer1.go 33.33% <0.00%> (+16.66%) ⬆️
layer1/ethereum/ethereum.go 42.68% <0.00%> (+42.68%) ⬆️
layer1/transaction/worker_pool.go 44.44% <0.00%> (+44.44%) ⬆️
layer1/tests/hardhat.go 53.35% <0.00%> (+53.35%) ⬆️
layer1/transaction/backend.go 60.34% <0.00%> (+59.47%) ⬆️
layer1/tests/setup.go 60.35% <0.00%> (+60.35%) ⬆️
layer1/transaction/transaction.go 69.64% <0.00%> (+69.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bridge/contracts/ATokenMinter.sol Show resolved Hide resolved
bridge/contracts/interfaces/IUtilityToken.sol Outdated Show resolved Hide resolved
removed duplicate struct definition
Made sure token minter/burner implements appropriate interfaces
@keirongulrajani keirongulrajani requested a review from a team as a code owner August 15, 2022 11:55
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 15, 2022
@vtleonardo vtleonardo changed the title Renamed AToken > ALCA/BToken > ALCB Rename AToken/BToken to ALCA/ALCB Aug 19, 2022
@nelsonhp nelsonhp merged commit ba8906f into alicenet:main Aug 19, 2022
@ghost ghost added the t/feature New feature or request label Aug 23, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
* added npm install

* changed npm install to npm ci in main.sh init script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code solidity t/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants