Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AToken contract #162

Merged
merged 22 commits into from
Aug 22, 2022
Merged

Refactor AToken contract #162

merged 22 commits into from
Aug 22, 2022

Conversation

vtleonardo
Copy link
Contributor

Scope

What is changing with this PR?

Why?

Why are we doing this?

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

@vtleonardo vtleonardo requested a review from a team as a code owner August 11, 2022 22:18
@vtleonardo vtleonardo marked this pull request as draft August 11, 2022 22:18
@codecov
Copy link

codecov bot commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #162 (786c13f) into main (dd49fd9) will decrease coverage by 3.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   51.69%   48.54%   -3.16%     
==========================================
  Files         283      283              
  Lines       41140    41140              
==========================================
- Hits        21268    19970    -1298     
- Misses      17450    18880    +1430     
+ Partials     2422     2290     -132
Impacted Files Coverage Δ
layer1/transaction/transaction.go 0.00% <0.00%> (-69.65%) ⬇️
layer1/executor/tasks/dkg/state/generate.go 0.00% <0.00%> (-63.37%) ⬇️
layer1/executor/tasks/dkg/tests/utils/setup.go 0.00% <0.00%> (-61.12%) ⬇️
layer1/tests/setup.go 0.00% <0.00%> (-60.36%) ⬇️
layer1/transaction/backend.go 0.87% <0.00%> (-59.48%) ⬇️
layer1/tests/hardhat.go 0.00% <0.00%> (-53.36%) ⬇️
layer1/transaction/worker_pool.go 0.00% <0.00%> (-44.45%) ⬇️
layer1/executor/tasks/dkg/state/state.go 0.00% <0.00%> (-44.30%) ⬇️
layer1/ethereum/ethereum.go 0.00% <0.00%> (-42.69%) ⬇️
layer1/executor/tasks/dkg/state/validate.go 0.00% <0.00%> (-36.67%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the go Pull requests that update Go code label Aug 16, 2022
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Aug 17, 2022
@vtleonardo vtleonardo changed the title WIP: Add initial work for multiplier Refactor AToken contract Aug 21, 2022
@github-actions github-actions bot removed the actions label Aug 21, 2022
@vtleonardo vtleonardo marked this pull request as ready for review August 21, 2022 23:44
@vtleonardo vtleonardo requested a review from a team as a code owner August 21, 2022 23:44
@nelsonhp nelsonhp merged commit bd218ca into alicenet:main Aug 22, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Migrating to go:embed for resources (#162)
870abd4 
* Migrating to go:embed for resources

* Fixing removed testDB breaking things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirongulrajani keirongulrajani keirongulrajani left review comments

@nelsonhp nelsonhp nelsonhp approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vtleonardo @keirongulrajani @nelsonhp @z-j-lin