Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warnings and regenerate some bindings #166

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

vtleonardo
Copy link
Contributor

Fixing some warnings that the solidity linter didn't get and adding some bindings that were not renegerated.

@vtleonardo vtleonardo requested review from a team as code owners August 13, 2022 12:23
@github-actions github-actions bot added go Pull requests that update Go code solidity labels Aug 13, 2022
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #166 (a69b5cb) into main (67cbb07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   53.37%   53.37%           
=======================================
  Files         338      338           
  Lines       43043    43043           
  Branches      367      367           
=======================================
  Hits        22973    22973           
  Misses      17639    17639           
  Partials     2431     2431           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from the go bindings side of things. I'm going to fix up the code owners so that generated files don't trigger reviewers.

@nelsonhp nelsonhp merged commit 800d0a3 into alicenet:main Aug 19, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants