Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity native errors improved #173

Merged

Conversation

keirongulrajani
Copy link
Contributor

Scope

Improved information with snapshots/ETHDKG related errors

Why?

MP-783

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

@keirongulrajani keirongulrajani requested a review from a team as a code owner August 15, 2022 14:46
@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #173 (9427914) into main (e020d73) will decrease coverage by 2.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   51.53%   48.57%   -2.96%     
==========================================
  Files         339      281      -58     
  Lines       43092    40912    -2180     
  Branches      358        0     -358     
==========================================
- Hits        22208    19875    -2333     
- Misses      18551    18748     +197     
+ Partials     2333     2289      -44     
Impacted Files Coverage Δ
layer1/executor/tasks/dkg/state/generate.go 0.00% <0.00%> (-63.37%) ⬇️
layer1/executor/tasks/dkg/tests/utils/setup.go 0.00% <0.00%> (-61.12%) ⬇️
layer1/executor/tasks/dkg/state/state.go 0.00% <0.00%> (-44.30%) ⬇️
layer1/executor/tasks/dkg/state/validate.go 0.00% <0.00%> (-36.67%) ⬇️
layer1/tests/setup.go 0.00% <0.00%> (-21.31%) ⬇️
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️
bridge/contracts/Snapshots.sol
...e/contracts/libraries/ethdkg/ETHDKGAccusations.sol
bridge/contracts/libraries/ethdkg/ETHDKGPhases.sol
...ridge/contracts/libraries/ethdkg/ETHDKGStorage.sol
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@keirongulrajani keirongulrajani requested a review from a team as a code owner August 15, 2022 15:48
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 15, 2022
@nelsonhp nelsonhp merged commit 493d9f7 into alicenet:main Aug 20, 2022
@ghost ghost added the t/feature New feature or request label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity t/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants