Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative imports #175

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

Scope

What is changing with this PR?

This PR is changing all solidity imports to use the absolute path from the bridge root. Using absolute imports make contracts debuggable on the remix and makes any renaming or change in path easier in the future.

@vtleonardo vtleonardo requested a review from a team as a code owner August 16, 2022 17:38
@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #175 (cb99d45) into main (2fbfdb0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   53.38%   53.37%   -0.02%     
==========================================
  Files         338      338              
  Lines       43043    43043              
  Branches      367      367              
==========================================
- Hits        22978    22973       -5     
- Misses      17638    17639       +1     
- Partials     2427     2431       +4     
Impacted Files Coverage Δ
bridge/contracts/AToken.sol 87.50% <ø> (ø)
...ntracts/libraries/parsers/BClaimsParserLibrary.sol 100.00% <ø> (ø)
...cts/libraries/parsers/MerkleProofParserLibrary.sol 100.00% <ø> (ø)
...ntracts/libraries/parsers/PClaimsParserLibrary.sol 100.00% <ø> (ø)
...contracts/libraries/parsers/RCertParserLibrary.sol 87.50% <ø> (ø)
...ntracts/libraries/parsers/RClaimsParserLibrary.sol 83.33% <ø> (ø)
...ts/libraries/parsers/TXInPreImageParserLibrary.sol 100.00% <ø> (ø)
bridge/contracts/utils/ERC20SafeTransfer.sol 100.00% <ø> (ø)
bridge/contracts/utils/ImmutableAuth.sol 52.11% <ø> (ø)
bridge/contracts/utils/MagicEthTransfer.sol 100.00% <ø> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nelsonhp nelsonhp merged commit f91ba26 into alicenet:main Aug 19, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
* Transitioning to buf to generate proto files
* Adding in linting, formating and breaking changes
* Setting some gitattributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants