Fixed bug in consensus

[ricardopinto]

Scope

What is changing with this PR?
Fixed a bug in consensus that would block it after an accusation was found. Shout out to @nelsonhp for helping debugging, identifying and fixing this one.

Why?

Why are we doing this?
Because otherwise consensus would halt forever after an accusation was found and the malicious validator was evicted.

Round of tests

Unit tests

• Consensus unit tests

Integration tests

• Deployment
• ETHDKG
• Consensus working normally without any transactions on the network
• Sync
• Snapshots
• Fast sync
• Consensus working normally with transactions on the network
• Sync while transactions are being processed by the network
• Fast sync while transactions are being processed by the network

[codecov]

Codecov Report

Merging #181 (2150719) into main (7269b95) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   53.38%   53.45%   +0.06%     
==========================================
  Files         338      338              
  Lines       43043    43042       -1     
  Branches      367      367              
==========================================
+ Hits        22978    23007      +29     
+ Misses      17641    17617      -24     
+ Partials     2424     2418       -6     

Impacted Files	Coverage Δ
consensus/lstate/statechnglocal.go	72.55% <100.00%> (+0.46%)	⬆️
badgerTrie/smt_merkle_proof.go	69.53% <0.00%> (ø)
consensus/objs/rs.go	60.65% <0.00%> (+0.78%)	⬆️
consensus/lstate/engine.go	53.21% <0.00%> (+1.89%)	⬆️
consensus/lstate/statecastlocal.go	57.10% <0.00%> (+2.18%)	⬆️
consensus/objs/pcn.go	41.30% <0.00%> (+3.26%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.