Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enumeration staking nft #183

Merged
merged 13 commits into from
Aug 19, 2022

Conversation

vtleonardo
Copy link
Contributor

Scope

ThIs PR adds:

  • Adds enumeration to the StakingNFT contracts so the FE can query the user's token IDs.
  • Cleans up the Staking contract to reduce duplication of code.

@vtleonardo vtleonardo requested review from a team as code owners August 18, 2022 21:33
@github-actions github-actions bot added go Pull requests that update Go code javascript Pull requests that update Javascript code solidity labels Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #183 (67c9d4c) into main (324a82e) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   48.50%   48.58%   +0.07%     
==========================================
  Files         281      281              
  Lines       40901    40900       -1     
==========================================
+ Hits        19841    19871      +30     
+ Misses      18758    18736      -22     
+ Partials     2302     2293       -9     
Impacted Files Coverage Δ
consensus/lstate/statechnglocal.go 72.55% <0.00%> (+0.46%) ⬆️
consensus/objs/rs.go 60.65% <0.00%> (+0.78%) ⬆️
peering/active.go 83.96% <0.00%> (+0.94%) ⬆️
consensus/lstate/engine.go 53.21% <0.00%> (+1.89%) ⬆️
consensus/lstate/statecastlocal.go 57.10% <0.00%> (+2.18%) ⬆️
consensus/objs/pcn.go 41.30% <0.00%> (+3.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nelsonhp nelsonhp merged commit a877bc0 into alicenet:main Aug 19, 2022
@ghost ghost added the t/feature New feature or request label Aug 23, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
* Optimizing jobs
* Removing outdated references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity t/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants