Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in version stamping #206

Merged
merged 11 commits into from
Aug 22, 2022
Merged

Adding in version stamping #206

merged 11 commits into from
Aug 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2022

Scope

  • Adding in version stamping into binary.

Why?

  • Allow us to ensure that all validators are running a supported version.

@github-actions github-actions bot added go Pull requests that update Go code javascript Pull requests that update Javascript code labels Aug 22, 2022
@github-actions github-actions bot removed the javascript Pull requests that update Javascript code label Aug 22, 2022
@ghost ghost changed the title Adding in version Adding in version stamping Aug 22, 2022
@ghost ghost marked this pull request as ready for review August 22, 2022 20:17
@ghost ghost self-requested a review as a code owner August 22, 2022 20:17
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #206 (d744858) into main (532fd0a) will increase coverage by 48.16%.
The diff coverage is 42.00%.

@@            Coverage Diff             @@
##            main     #206       +/-   ##
==========================================
+ Coverage   5.20%   53.36%   +48.16%     
==========================================
  Files        164      343      +179     
  Lines      20898    43519    +22621     
  Branches       0      369      +369     
==========================================
+ Hits        1087    23226    +22139     
+ Misses     19705    17867     -1838     
- Partials     106     2426     +2320     
Impacted Files Coverage Δ
config/settings.go 20.00% <ø> (ø)
layer1/monitor/events/dynamics.go 0.00% <0.00%> (ø)
layer1/executor/tasks/dynamics/version_check.go 89.65% <25.00%> (ø)
utils/dynamics.go 59.45% <57.57%> (+59.45%) ⬆️
consensus/lstate/localstate.go 73.28% <0.00%> (ø)
layer1/monitor/events/validators.go 0.00% <0.00%> (ø)
peering/inactive.go 0.00% <0.00%> (ø)
layer1/executor/tasks/snapshots/snapshot.go 0.00% <0.00%> (ø)
...ntracts/libraries/parsers/BClaimsParserLibrary.sol 100.00% <0.00%> (ø)
application/utxohandler/utxotrie/utxotrie.go 26.91% <0.00%> (ø)
... and 319 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost ghost requested a review from nelsonhp August 22, 2022 20:28

version := config.Configuration.Version
if version == "dev" {
return canonicalVersion, ErrDevelopmentVersion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic concerns me because it may cause a failure of the node to run or a failure of the monitoring task to work as expected. I want to discuss with you before merge.

@nelsonhp nelsonhp merged commit ef9e94c into main Aug 22, 2022
@nelsonhp nelsonhp deleted the versioning branch August 22, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant