-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in version stamping #206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 5.20% 53.36% +48.16%
==========================================
Files 164 343 +179
Lines 20898 43519 +22621
Branches 0 369 +369
==========================================
+ Hits 1087 23226 +22139
+ Misses 19705 17867 -1838
- Partials 106 2426 +2320
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
version := config.Configuration.Version | ||
if version == "dev" { | ||
return canonicalVersion, ErrDevelopmentVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic concerns me because it may cause a failure of the node to run or a failure of the monitoring task to work as expected. I want to discuss with you before merge.
Scope
Why?