Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename validator CLI command to node and add default CLI values #230

Merged
4 commits merged into from
Sep 8, 2022

Conversation

kosegor
Copy link
Contributor

@kosegor kosegor commented Aug 30, 2022

Scope

Addressing both tickets:
https://madhive.atlassian.net/browse/MP-842
https://madhive.atlassian.net/browse/MP-843

Now the user is able to start a node using only ./alicenet command

Why?

To improve user experience

@kosegor kosegor requested a review from a team as a code owner August 30, 2022 19:46
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #230 (a201268) into main (f668c43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   53.39%   53.39%           
=======================================
  Files         343      343           
  Lines       43527    43527           
  Branches      369      369           
=======================================
  Hits        23240    23240           
  Misses      17874    17874           
  Partials     2413     2413           
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vtleonardo vtleonardo changed the title cli fixes Rename validator CLI command to node and add default CLI values Aug 30, 2022
@vtleonardo
Copy link
Contributor

LGTM!

@kosegor kosegor requested a review from nelsonhp August 31, 2022 15:14
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!

cmd/main.go Show resolved Hide resolved
@ghost ghost merged commit f7c4905 into alicenet:main Sep 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants