Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicall multicontract #27

Merged
merged 10 commits into from
Jul 1, 2022
Merged

Conversation

gusjavaz
Copy link
Contributor

@gusjavaz gusjavaz commented Jun 29, 2022

Scope

This PR adds two new hardhat tasks:

  1. generateContractsDescriptor: Generates a JSON descriptor file with all contract deployment information requirements using (slow) function getBuildInfo (requires deploymentList and deploymentArgsTemplate files to be already generated) .
  2. deployContractsFromDescriptor: Deploy contracts faster with information from previously created JSON file.

Why?

To speed up contract deployment through deployContracts current task, tests shows deployContractsFromDescriptor is 5 times faster against hardhat node and almost 2 times faster against geth.

Copy link
Contributor

@z-j-lin z-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to run npm run lint -- --fix

bridge/scripts/lib/deployment/deploymentUtil.ts Outdated Show resolved Hide resolved
bridge/scripts/lib/deployment/deploymentUtil.ts Outdated Show resolved Hide resolved
bridge/scripts/lib/deployment/deploymentUtil.ts Outdated Show resolved Hide resolved
bridge/scripts/lib/deployment/deploymentUtil.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3f85bc4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   45.02%           
=======================================
  Files           ?      220           
  Lines           ?    40002           
  Branches        ?        0           
=======================================
  Hits            ?    18012           
  Misses          ?    20023           
  Partials        ?     1967           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f85bc4...8286bbe. Read the comment docs.

@gusjavaz gusjavaz requested a review from z-j-lin July 1, 2022 14:10
Copy link
Contributor

@z-j-lin z-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to go

@z-j-lin z-j-lin merged commit 1899ed9 into alicenet:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants