Refactor accusations #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopinto
suggested changes
Jul 13, 2022
bridge/test/accusations/invalid-transaction-consumption-accusations.test.ts
Outdated
Show resolved
Hide resolved
ricardopinto
suggested changes
Jul 13, 2022
keirongulrajani
force-pushed
the
refactor-accusations
branch
from
2c01be6
to
e0d5cd4
Compare
github-actions
bot
added
javascript
ricardopinto
approved these changes
Jul 14, 2022
ricardopinto
suggested changes
Jul 14, 2022
bridge/test/accusations/invalid-transaction-consumption-accusations.test.ts
Outdated
Show resolved
Hide resolved
Shortened contract name to fix salt generation
Generated Immutable auth
Updated accusation error codes
keirongulrajani
force-pushed
the
refactor-accusations
branch
from
e0d5cd4
to
2934b26
Compare
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 45.62% 45.61% -0.02%
==========================================
Files 214 214
Lines 38503 38503
==========================================
- Hits 17568 17563 -5
- Misses 19005 19006 +1
- Partials 1930 1934 +4
Continue to review full report at Codecov.
|
ricardopinto
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
salt-typeparameter for immutable factory, allowing for a defined contract type to be included in the salt calculationWhy?
MP-590
MP-551
Todos
If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?