Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing golangci-lint run #33

Merged
1 commit merged into from
Jul 2, 2022
Merged

Optimizing golangci-lint run #33

1 commit merged into from
Jul 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2022

Scope

  • Go lint step already installs golang

Why?

  • One less step to run

@codecov-commenter
Copy link

Codecov Report

Merging #33 (cf775f8) into main (5c128b5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   45.03%   45.02%   -0.01%     
==========================================
  Files         220      220              
  Lines       40002    40002              
==========================================
- Hits        18013    18011       -2     
- Misses      20022    20024       +2     
  Partials     1967     1967              
Impacted Files Coverage Δ
transport/transport.go 77.68% <0.00%> (-1.66%) ⬇️
badgerTrie/smt_merkle_proof.go 60.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c128b5...cf775f8. Read the comment docs.

@ghost ghost merged commit d726ce4 into main Jul 2, 2022
@ghost ghost deleted the fixup-golint branch July 2, 2022 03:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant