Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Hardhat setup #36

Merged
merged 214 commits into from
Jul 12, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

Scope

This PR is refactoring how the hardhat node is executed by the golang unit tests. This PR is removing the dependency on the bash scripts and executing hardhat and the deploy scripts directly. In addition to this, all the integration tests are being fixed to work with the new code (after the layer1 refactoring).

Why?

All unit tests should pass after the big refactoring :)

Blocked by #11

vtleonardo and others added 30 commits May 3, 2022 16:19
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding that we're going to cleanup after all PR's are merged.

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jul 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #36 (0703a2c) into main (68abddf) will increase coverage by 0.59%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   45.03%   45.63%   +0.59%     
==========================================
  Files         220      214       -6     
  Lines       40002    38484    -1518     
==========================================
- Hits        18016    17563     -453     
+ Misses      20023    18989    -1034     
+ Partials     1963     1932      -31     
Impacted Files Coverage Δ
config/settings.go 0.00% <ø> (ø)
layer1/executor/tasks/dkg/utils/utils.go 7.69% <ø> (ø)
layer1/monitor/objects/event_map.go 0.00% <ø> (ø)
layer1/monitor/objects/state.go 0.00% <ø> (ø)
layer1/transaction/backend.go 0.86% <ø> (ø)
layer1/transaction/errors.go 0.00% <ø> (ø)
layer1/transaction/transaction.go 0.00% <ø> (ø)
layer1/transaction/worker_pool.go 0.00% <ø> (ø)
utils/leader_election.go 0.00% <ø> (ø)
utils/shared.go 56.36% <ø> (-26.31%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b541468...0703a2c. Read the comment docs.

@vtleonardo vtleonardo changed the title Fix the Hardhat setup and integrations tests in the golang code Fix the Hardhat setup Jul 12, 2022
@vtleonardo vtleonardo merged commit 24cc812 into alicenet:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions go Pull requests that update Go code javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants