-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Hardhat setup #36
Fix the Hardhat setup #36
Conversation
This reverts commit 69afcc3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the understanding that we're going to cleanup after all PR's are merged.
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 45.03% 45.63% +0.59%
==========================================
Files 220 214 -6
Lines 40002 38484 -1518
==========================================
- Hits 18016 17563 -453
+ Misses 20023 18989 -1034
+ Partials 1963 1932 -31
Continue to review full report at Codecov.
|
Scope
This PR is refactoring how the hardhat node is executed by the golang unit tests. This PR is removing the dependency on the bash scripts and executing hardhat and the deploy scripts directly. In addition to this, all the integration tests are being fixed to work with the new code (after the layer1 refactoring).
Why?
All unit tests should pass after the big refactoring :)
Blocked by #11