Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript linter execution #442

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

Scope

The typescript linter was ignoring some files due to missing quotations of the paths in the npm script definition. This PR solves this bug and fixes all linter errors found in the typescript files.

@vtleonardo vtleonardo requested a review from a team as a code owner October 27, 2022 19:32
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 54.30% // Head: 54.25% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (97fca2d) compared to base (4c3b5a1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   54.30%   54.25%   -0.05%     
==========================================
  Files         343      343              
  Lines       43039    43039              
  Branches      544      544              
==========================================
- Hits        23371    23351      -20     
- Misses      17184    17193       +9     
- Partials     2484     2495      +11     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️
layer1/executor/task_manager.go 71.59% <0.00%> (-2.69%) ⬇️
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@z-j-lin z-j-lin merged commit 2db0b57 into alicenet:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants