Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust deploy script to be compatible with geth #464

Merged
1 commit merged into from
Nov 3, 2022

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Nov 3, 2022

This PR should make the scripts compatible with geth and hardhat at cost of making the deployment on hardhat a little bit slower.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 82.21% // Head: 54.02% // Decreases project coverage by -28.19% ⚠️

Coverage data is based on head (52a789a) compared to base (5882f97).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #464       +/-   ##
===========================================
- Coverage   82.21%   54.02%   -28.20%     
===========================================
  Files          61      339      +278     
  Lines        2002    42396    +40394     
  Branches      547      547               
===========================================
+ Hits         1646    22904    +21258     
- Misses        356    17038    +16682     
- Partials        0     2454     +2454     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (ø)
application/indexer/heightidx.go 89.15% <0.00%> (ø)
utils/dynamics.go 59.45% <0.00%> (ø)
consensus/objs/nrclaims/nextround.go 43.24% <0.00%> (ø)
consensus/objs/vset/vset.go 47.05% <0.00%> (ø)
consensus/db/db.go 52.71% <0.00%> (ø)
application/objs/ds.go 78.02% <0.00%> (ø)
consensus/objs/ovs.go 52.33% <0.00%> (ø)
application/objs/owner.go 78.82% <0.00%> (ø)
consensus/objs/pnkey.go 75.00% <0.00%> (ø)
... and 268 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost merged commit 8b2f1b4 into alicenet:main Nov 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants