Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

291 Clean structtag #522

Merged
1 commit merged into from
Nov 23, 2022
Merged

291 Clean structtag #522

1 commit merged into from
Nov 23, 2022

Conversation

pbains
Copy link
Contributor

@pbains pbains commented Nov 23, 2022

Scope

Minor issue with structtag problem

Why?

Code clean up

@github-actions github-actions bot added the go Pull requests that update Go code label Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 53.90% // Head: 54.37% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (472f8fa) compared to base (1a4312e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   53.90%   54.37%   +0.46%     
==========================================
  Files         345      369      +24     
  Lines       42685    42699      +14     
  Branches      599      599              
==========================================
+ Hits        23011    23218     +207     
+ Misses      17239    17022     -217     
- Partials     2435     2459      +24     
Impacted Files Coverage Δ
layer1/executor/model.go 82.75% <ø> (ø)
bridge/contracts/Foundation.sol 37.50% <0.00%> (-12.50%) ⬇️
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️
bridge/contracts/AliceNetFactory.sol 89.74% <0.00%> (-0.74%) ⬇️
bridge/contracts/ValidatorPool.sol 88.71% <0.00%> (-0.34%) ⬇️
bridge/contracts/ETHDKG.sol 84.42% <0.00%> (-0.13%) ⬇️
bridge/contracts/Snapshots.sol 93.80% <0.00%> (-0.06%) ⬇️
bridge/contracts/BToken.sol 94.87% <0.00%> (-0.05%) ⬇️
bridge/contracts/Lockup.sol 97.32% <0.00%> (-0.02%) ⬇️
bridge/contracts/Proxy.sol 100.00% <0.00%> (ø)
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pbains pbains marked this pull request as ready for review November 23, 2022 13:23
@pbains pbains requested a review from a team as a code owner November 23, 2022 13:23
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost merged commit 455eb1a into main Nov 23, 2022
@ghost ghost deleted the pbains/291-lint-struct branch November 23, 2022 16:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant