Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky lockup test #524

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix flaky lockup test #524

merged 1 commit into from
Nov 28, 2022

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Nov 23, 2022

This test is failing sometimes depending on the gas used and at which point it gets executed. The right way to check the values that can have possible rounding errors is by subtracting one from another and checking if the error falls into an acceptable range.

@vtleonardo vtleonardo requested a review from a team as a code owner November 23, 2022 16:57
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 18.12% // Head: 54.36% // Increases project coverage by +36.23% 🎉

Coverage data is based on head (cb498a0) compared to base (455eb1a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #524       +/-   ##
===========================================
+ Coverage   18.12%   54.36%   +36.23%     
===========================================
  Files         288      369       +81     
  Lines       27741    42708    +14967     
  Branches      599      599               
===========================================
+ Hits         5029    23217    +18188     
+ Misses      22513    17029     -5484     
- Partials      199     2462     +2263     
Impacted Files Coverage Δ
consensus/request/handlers.go 81.08% <0.00%> (ø)
middleware/peer.go 86.66% <0.00%> (ø)
layer1/executor/tasks/examples/simple_task.go 0.00% <0.00%> (ø)
transport/upnp.go 0.00% <0.00%> (ø)
peering/bootlistener.go 0.00% <0.00%> (ø)
consensus/dman/dman.go 42.44% <0.00%> (ø)
peering/inactive.go 0.00% <0.00%> (ø)
peering/p2pbus.go 0.00% <0.00%> (ø)
consensus/lstate/localstate.go 73.28% <0.00%> (ø)
localrpc/handlers.go 26.48% <0.00%> (ø)
... and 232 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@z-j-lin z-j-lin merged commit 154f52d into main Nov 28, 2022
@z-j-lin z-j-lin deleted the fix-flaky-lockup-test branch November 28, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants