Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level on killed tasks #63

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

Scope

When a task is being killed (e.g snapshots) its context (created by the scheduler) is canceled which bubbles up an error. This is normal behavior and should be filtered to not show to the user the message as a level Error. The error level should be only used when I task exits with an error without being killed.

@vtleonardo vtleonardo requested a review from a user July 13, 2022 12:35
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #63 (e18541c) into main (dff6b0e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   45.65%   45.63%   -0.03%     
==========================================
  Files         214      214              
  Lines       38484    38499      +15     
==========================================
- Hits        17569    17568       -1     
- Misses      18988    19001      +13     
- Partials     1927     1930       +3     
Impacted Files Coverage Δ
layer1/executor/task_scheduler.go 1.16% <0.00%> (-0.05%) ⬇️
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️
badgerTrie/smt_merkle_proof.go 64.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff6b0e...e18541c. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vtleonardo vtleonardo merged commit fee293c into alicenet:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants