Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backoff multiplier in the tx retries #64

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Jul 13, 2022

Scope

The multiplier between retries during some edge cases on the transaction watcher should wait for the first retry to be applied. This PR also fixes a small bug where the correct polling time was not being applied to the watcher backend.

@vtleonardo vtleonardo requested a review from a user July 13, 2022 12:46
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #64 (e7af66b) into main (dff6b0e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   45.65%   45.64%   -0.01%     
==========================================
  Files         214      214              
  Lines       38484    38488       +4     
==========================================
- Hits        17569    17568       -1     
- Misses      18988    18990       +2     
- Partials     1927     1930       +3     
Impacted Files Coverage Δ
layer1/transaction/backend.go 0.86% <0.00%> (ø)
layer1/transaction/worker_pool.go 0.00% <0.00%> (ø)
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️
badgerTrie/smt_merkle_proof.go 64.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff6b0e...e7af66b. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vtleonardo vtleonardo merged commit 2d3197d into alicenet:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants