Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added merkle proof library tests #66

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

keirongulrajani
Copy link
Contributor

Scope

Rewritten Merkle tree library tests in typescript

Why?

MP-518

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Jul 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #66 (e28fadd) into main (8b0e99c) will increase coverage by 3.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   45.62%   48.94%   +3.32%     
==========================================
  Files         214      287      +73     
  Lines       38503    42317    +3814     
==========================================
+ Hits        17567    20713    +3146     
- Misses      19006    19248     +242     
- Partials     1930     2356     +426     
Impacted Files Coverage Δ
layer1/executor/task_scheduler.go 1.15% <0.00%> (-0.01%) ⬇️
layer1/executor/tasks/dkg/utils/utils.go 7.69% <0.00%> (ø)
proto/p2p_grpc.pb.go
proto/localstatetypes.pb.go
proto/bootnode_grpc.pb.go
proto/localstate.pb.go
proto/bootnode.pb.go
cmd/firewalld/gcloud/gcloud.go
proto/localstate_grpc.pb.go
cmd/firewalld/firewalld.go
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0e99c...e28fadd. Read the comment docs.

@vtleonardo
Copy link
Contributor

LGTM, just fix the linter warning https://github.com/alicenet/alicenet/runs/7406225098?check_suite_focus=true on the file bridge/test/merkleProof/merkle-proof-library.test.ts and we should be good to merge this.

@vtleonardo vtleonardo self-requested a review July 20, 2022 13:17
vtleonardo
vtleonardo previously approved these changes Jul 21, 2022
@vtleonardo vtleonardo self-requested a review July 21, 2022 13:48
@vtleonardo vtleonardo dismissed their stale review July 21, 2022 13:49

Linter warnings should be fixed before approval

@vtleonardo vtleonardo merged commit 6f45c30 into alicenet:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants