Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamics contract #71

Merged
merged 68 commits into from
Aug 21, 2022
Merged

Add dynamics contract #71

merged 68 commits into from
Aug 21, 2022

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Jul 14, 2022 •
edited

Scope

This PR is:

  • Adding the dynamics smart contracts
  • Adding the canonical version logic and update handling

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022 •
edited by codecov bot

Codecov Report

Merging #71 (9f4321a) into main (70ee80d) will decrease coverage by 1.74%.
The diff coverage is 32.33%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   53.43%   51.68%   -1.75%     
==========================================
  Files         339      283      -56     
  Lines       43185    41140    -2045     
  Branches      358        0     -358     
==========================================
- Hits        23074    21264    -1810     
+ Misses      17689    17453     -236     
- Partials     2422     2423       +1
Impacted Files Coverage Δ
layer1/ethereum/contracts.go 0.00% <0.00%> (ø)
layer1/executor/task_scheduler.go 1.16% <0.00%> (-0.01%) ⬇️
layer1/monitor/events/dynamics.go 0.00% <0.00%> (ø)
layer1/monitor/events/setup.go 5.64% <0.00%> (-0.89%) ⬇️
layer1/monitor/monitor.go 0.00% <0.00%> (ø)
layer1/monitor/objects/state.go 0.00% <ø> (ø)
layer1/executor/tasks/dynamics/version_check.go 100.00% <100.00%> (ø)
utils/dynamics.go 100.00% <100.00%> (ø)
bridge/contracts/Snapshots.sol
...contracts/libraries/snapshots/SnapshotsStorage.sol
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost ghost marked this pull request as draft July 20, 2022 14:08
vtleonardo and others added 20 commits July 21, 2022 13:24
@vtleonardo
Add initial implementation of the doubly linked list
733add3
@vtleonardo
Move linked list as library
b42f216
@vtleonardo
Merge remote-tracking branch 'upstream/main' into add-dynamics-contract
f7d553f
@vtleonardo
Add more features to doubly linked list
4fc3862
@vtleonardo
Merge remote-tracking branch 'upstream/main' into add-dynamics-contract
b68895d
@vtleonardo
Finish doubly linked list logic
6b18b34
@vtleonardo
Push work in progress dynamics
7de171e
@z-j-lin
added storage contract functions
ad3cbd4
@vtleonardo
Add suggestions to doublylinked list logic
fff3431
@vtleonardo
Merge branch 'add-dynamics-contract' of github.com:vtleonardo/alicene…
bb84140 
…t into add-dynamics-contract
@vtleonardo
Fix prefix on deterministic deployment
f101a4e
@vtleonardo
Merge remote-tracking branch 'upstream/main' into add-dynamics-contract
6c33108
@vtleonardo
Add stable version of dynamics
b3fe31e
@vtleonardo
Fix error unreacheable code
9b3eb1a
@vtleonardo
Add missing requre
8e767ee
@z-j-lin
fixed _decodeDynamicValues
71df5fd
@z-j-lin
fully working dynamic value decoder
fdc388f
@vtleonardo
Fix linter
c0828fb
@vtleonardo
Add checks to alicenet node versioning
8ca0ce7
@z-j-lin
fixed shifting error in computCompactedVersion
b708178
@vtleonardo vtleonardo changed the title WIP: Add dynamics contract Add dynamics contract Aug 10, 2022
@vtleonardo vtleonardo marked this pull request as ready for review August 10, 2022 19:51
@vtleonardo vtleonardo requested a review from a team as a code owner August 10, 2022 19:51
vtleonardo and others added 8 commits August 19, 2022 21:29
@vtleonardo
More clean up
45054ca
@vtleonardo
More clean up
57e827b
@vtleonardo
More clean up
1c7dced
@vtleonardo
More clean up
020cb61
@vtleonardo
Clean up the dynamics contract
ee99503
@vtleonardo
Merge remote-tracking branch 'upstream/main' into add-dynamics-contract
f86f15a
@vtleonardo
Fix conflicts
398f437
@kosegor @vtleonardo
Add Version check (#57)
0b85971 
* adding new event to monitor, new task created

* task done, monitor close func changed, started with validator

* updating Dynamics contract and event

* finished validator, added tests for the monitor events

* tasks tests, new hardhat cmd to test locally

* fix cmd, fix bug

* raising the mocked version to safe one and tweaking tests

Co-authored-by: Leonardo Viana Teixeira <leo.mec.eng18@gmail.com>
@vtleonardo vtleonardo changed the title WIP: Add dynamics contract Add dynamics contract Aug 20, 2022
@vtleonardo vtleonardo marked this pull request as ready for review August 20, 2022 12:55
@vtleonardo vtleonardo requested a review from a team as a code owner August 20, 2022 12:55
@vtleonardo vtleonardo enabled auto-merge (squash) August 21, 2022 17:06
@vtleonardo vtleonardo merged commit ada6a18 into alicenet:main Aug 21, 2022
@ghost ghost added the t/feature New feature or request label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonhp nelsonhp nelsonhp approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity t/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vtleonardo @codecov-commenter @nelsonhp @z-j-lin @kosegor