Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Bonding Curve #92

Merged
merged 15 commits into from
Jul 22, 2022
Merged

Updated Bonding Curve #92

merged 15 commits into from
Jul 22, 2022

Conversation

chgorman
Copy link
Contributor

Scope

Changed magic numbers into constants which parameterize the function.

Why?

The code becomes easier to read.

Todos

At some point, add reference to bonding curve article.

@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #92 (a0ada18) into main (0a46e68) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   48.94%   48.93%   -0.02%     
==========================================
  Files         287      287              
  Lines       42317    42317              
==========================================
- Hits        20712    20707       -5     
- Misses      19249    19250       +1     
- Partials     2356     2360       +4
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a46e68...a0ada18. Read the comment docs.

vtleonardo
vtleonardo reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@vtleonardo vtleonardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the solidity linter issues and we should be good to merge on my side.

bridge/contracts/libraries/math/Sigmoid.sol Outdated Show resolved Hide resolved
bridge/test/contract-mocks/math/MockSigmoid.sol Show resolved Hide resolved
@vtleonardo vtleonardo merged commit 68726e4 into alicenet:main Jul 22, 2022
@chgorman chgorman deleted the bondingCurveUpdate branch July 23, 2022 21:19
@chgorman chgorman restored the bondingCurveUpdate branch July 23, 2022 21:23
@chgorman chgorman deleted the bondingCurveUpdate branch July 25, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtleonardo vtleonardo vtleonardo approved these changes

@nelsonhp nelsonhp Awaiting requested review from nelsonhp

@z-j-lin z-j-lin Awaiting requested review from z-j-lin

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code solidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chgorman @vtleonardo