Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise solidity linter warning to errors #93

Merged
3 commits merged into from
Jul 21, 2022

Conversation

vtleonardo
Copy link
Contributor

Scope

This PR should make the linter CI job fail when smart contracts are committed without respecting the linter rules.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #93 (2e79543) into main (1d80e73) will increase coverage by 3.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   45.61%   48.94%   +3.33%     
==========================================
  Files         214      287      +73     
  Lines       38504    42317    +3813     
==========================================
+ Hits        17563    20712    +3149     
- Misses      19007    19249     +242     
- Partials     1934     2356     +422     
Impacted Files Coverage Δ
cmd/firewalld/firewalld.go
cmd/firewalld/gcloud/gcloud.go
proto/p2p_mngen.go
proto/aobjs.pb.go
proto/bootnode_grpc.pb.go
proto/bootnode.pb.go
proto/p2p_grpc.pb.go
cmd/firewalld/gcloud/metadata.go
cmd/firewalld/gcloud/fwrule.go
proto/localstate_grpc.pb.go
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d80e73...2e79543. Read the comment docs.

@vtleonardo vtleonardo requested a review from a user July 21, 2022 11:13
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Jul 21, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost merged commit 0a46e68 into alicenet:main Jul 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant