Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation failing if include/${MODULE_NAME} is not existing #256

Closed
matthiasrichter opened this issue Mar 8, 2017 · 1 comment
Closed

Installation failing if include/${MODULE_NAME} is not existing #256

matthiasrichter opened this issue Mar 8, 2017 · 1 comment

Comments

@matthiasrichter
Copy link
Collaborator

The installation fails if the directory for public headers is missing. That's a rare case but possible for a module with only executables and no public headers.
@matthiasrichter
Copy link
Collaborator Author

I can combine this with #254 in one PR

matthiasrichter added a commit to matthiasrichter/AliceO2 that referenced this issue Mar 9, 2017
@matthiasrichter
Fix AliceO2Group#254 and Fix AliceO2Group#256 in O2Utils.cmake
71e0335 
Fix AliceO2Group#254: Automatically find internal header files in module's src directory
Fix AliceO2Group#256: conditional installation of public headers
@matthiasrichter matthiasrichter mentioned this issue Mar 9, 2017
Merged
@ktf ktf closed this as completed in #257 Mar 13, 2017
ktf pushed a commit that referenced this issue Mar 13, 2017
@matthiasrichter @ktf
Fix #254 and Fix #256 in O2Utils.cmake (#257)
97fdc9b 
Fix #254: Automatically find internal header files in module's src directory
Fix #256: conditional installation of public headers
@matthiasrichter matthiasrichter mentioned this issue Apr 12, 2017
Merged
matthiasrichter added a commit to matthiasrichter/AliceO2 that referenced this issue Apr 20, 2017
@matthiasrichter
Fix AliceO2Group#296: Installation of public header files
438e714 
This is related to AliceO2Group#256, the previous fix in AliceO2Group#257 introduced
a bug skipping header file installation completely. The
check for existence of public header directory needs the
CMAKE_CURRENT_SOURCE_DIR in the directory path.
@matthiasrichter matthiasrichter mentioned this issue Apr 20, 2017
Merged
ktf pushed a commit that referenced this issue Apr 20, 2017
@matthiasrichter @ktf
Fix #296: Installation of public header files
e7bfe3b 
This is related to #256, the previous fix in #257 introduced
a bug skipping header file installation completely. The
check for existence of public header directory needs the
CMAKE_CURRENT_SOURCE_DIR in the directory path.
mikesas pushed a commit to mikesas/AliceO2 that referenced this issue Dec 13, 2022
@jgrosseo
enable warnings (AliceO2Group#256)
586d9d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthiasrichter