Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add software to filter SfM data and to create landmarks-based masking for depth map computation #1526

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    d99edd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    feaa520 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6aa4ef3 View commit details
    Browse the repository at this point in the history
  4. [filterSfM] fix bug

    - OpenMP loop race problem
    - inverse if condition
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5ab39e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31d10b5 View commit details
    Browse the repository at this point in the history
  6. [prepareDenseScene] fix landmarks-based mask for depth maps

    - put masked pixels to 0.5 instead of 0 in order to be taken into consideration for Tc cameras
    - fix index out of range thrown in case there are no observations for a certain view
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ea9a153 View commit details
    Browse the repository at this point in the history
  7. [filterSfM] add option for not using feature scale

    when computing pixel size
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    160c7bb View commit details
    Browse the repository at this point in the history
  8. [filterSfM] fix bug

    - fix reference and constantness problem
    - fix pre-allocation of vector
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    309e771 View commit details
    Browse the repository at this point in the history
  9. [filterSfM] add new landmark filtering option

    filter unstable landmarks that have an insufficient number of observations (specified as a parameter)
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    73c6222 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    36abb24 View commit details
    Browse the repository at this point in the history
  11. [prepareDenseScene] add 2D observation filtering for depth map mask

    If a 2D projected observation in a view doesn't have enough other
    neighboring observations, it will not be considered for creating
    the depth map mask
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a5e8959 View commit details
    Browse the repository at this point in the history
  12. [prepareDenseScene] improve 2D observation filtering

    - estimate the mask radius dynamically for each view
    based on average distance to neighbors
    - filter 2D observations based on quantile on distribution
    of average distance to neighbors
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6340c92 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c3865a7 View commit details
    Browse the repository at this point in the history
  14. [filterSfM] fix KdTree search

    a point is neighbor to itself if it participated in creating the tree
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    583342c View commit details
    Browse the repository at this point in the history
  15. [filterSfM] fix references

    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a8c6086 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    278b592 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    44cee47 View commit details
    Browse the repository at this point in the history
  18. [filterSfM] add comments

    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    52ff5cc View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    09c2aba View commit details
    Browse the repository at this point in the history
  20. [filterSfM] fix NaN

    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    28299cb View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a7ac8c7 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    7edd783 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    2d5d4e5 View commit details
    Browse the repository at this point in the history
  24. [filterSfM] improve landmarks filtering

    remove landmarks that don't have enough common observations with their neighbors
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    47048d8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    95dbe2c View commit details
    Browse the repository at this point in the history
  26. [filterSfM] improve observation selection strategy

    - add a re-distribution of observation scores at each iteration by favouring best N observations
    that will be selected at the end
    - fix hard-coded parameters
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1483c70 View commit details
    Browse the repository at this point in the history
  27. [filterSfM] multiple improvements

    - update parameters and code structure for a clearer understanding of different steps
    - fix bug with damping renormalization
    - add comments
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7f344ce View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    8a0b9aa View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    416e6a8 View commit details
    Browse the repository at this point in the history
  30. [WIP][filterSfM] multiple improvements and fixes

    - resolve duplicate features issue
    - do not normalize propagated neighbors scores
    - fix NaN MSE issue
    - fix radius estimation caused by quantile issue
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    eb36bcc View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    5828fa1 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    5c5b7d4 View commit details
    Browse the repository at this point in the history
  33. [WIP][filterSfM] multiple improvements

    - add option to propagate neighbor observations
    - use Jaccard index in step 2
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0278a7b View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7d394fb View commit details
    Browse the repository at this point in the history
  35. [filterSfM] add option to keep propagated observations

    at the end of 3D Observations filter
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    98cea2f View commit details
    Browse the repository at this point in the history
  36. [WIP][filterSfM] fix option to keep propagated observations

    - create a fake observation by projecting the landmark in the view
    almarouk committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d76e166 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    27a1b64 View commit details
    Browse the repository at this point in the history