Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/deprecated boost timers #164

Merged
merged 4 commits into from
Jun 20, 2021
Merged

Fix/deprecated boost timers #164

merged 4 commits into from
Jun 20, 2021

Conversation

griwodz
Copy link
Member

@griwodz griwodz commented Jun 19, 2021 •
edited
Loading

Description

No functional change. Several minor fixes.

Follow-up for PR #162 .

Features list

  • Fixed deprecated boost timers. Deprecated boost timers may exist for a while longer, but fixing it now avoids a lot of meaningless warnings during compilation.
  • Removed an unused variable to avoid a warning.
  • Expanded LD_LIBRARY_PATH in continuous integration.
  • Avoid redundant array initialisations of LUTs in CPU-size Canny. A compiler may notice and avoid the copy, but in principle, the code demands a huge number of builtin_memcpy calls.

Implementation remarks

@griwodz griwodz self-assigned this Jun 19, 2021
@griwodz griwodz added this to the v1.0.0 milestone Jun 19, 2021
@griwodz griwodz requested a review from simogasp June 19, 2021 08:58
@griwodz griwodz mentioned this pull request Jun 19, 2021
Closed
Base automatically changed from fix/visualDebugNewOpenCV to develop June 19, 2021 18:01
@griwodz
Copy link
Member Author

griwodz commented Jun 19, 2021

@simogasp Codacy refuses to re-run for me. Do I have to make a new PR or add a dummy commit?

@simogasp
Copy link
Member

simogasp commented Jun 20, 2021 •
edited
Loading

it's working now.
I'd avoid to replicate the commits from other branches. I rebased the branch with the current develop and removed the commit about the visualDebug. It's all good now.

simogasp
simogasp approved these changes Jun 20, 2021
View reviewed changes
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simogasp simogasp merged commit 5df3be6 into develop Jun 20, 2021
@simogasp simogasp deleted the fix/deprecatedBoostTimers branch June 20, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simogasp simogasp simogasp approved these changes

Assignees

@griwodz griwodz

Labels
prio:minor
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@griwodz @simogasp