Compatilibity with Boost 1.65 #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Boost versions such as 1.65 (default Ubuntu 18.04) declare the virtual clone method in error_info_base. This makes this class abstract and not compile.
fabiencastan
approved these changes
Jun 20, 2018
fabiencastan
requested changes
Jun 20, 2018
| @@ -73,6 +73,8 @@ class error_info<Tag, error_info_sstream>: public exception_detail::error_info_b | |||
| _value._v << value; | |||
| } | |||
|
|
|||
| error_info_base * clone() const {} | |||
There was a problem hiding this comment.
Are we not supposed to do something like that?
error_info_base * clone() const
{
error_info* p = new error_info();
*p = *this;
return p;
}
To create a new instance with the same content.
There was a problem hiding this comment.
Yes, absolutely. That looks correct.
|
FYI in #78 I'm gonna get rid of all boost exception stuff and use simple std::exception. |
simogasp
approved these changes
Jun 20, 2018
|
Created a new PR #82 with the discussed fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Boost versions such as 1.65 (default Ubuntu 18.04) declare the virtual clone method in error_info_base. This makes this class abstract and not compile.