Skip to content
Simone Gasparini edited this page Jun 1, 2020 · 3 revisions

Todo clean up code

  • Namespaces: make them more coherent with folder structure

    • remove numerical namespace
    • use only a sub-namespace with the same name as the sub-folder
    • introduce a namespace for cuda? currently only cctag
    • use only cctag as namespace?
  • move Operations inside geometry

  • use pragma once instead of ifdef (they are not consistent)

  • order includes (clang-format rule)

Questions

  • Do we really need ICCTag? What is the purpose? To have a different representation of the cctag in the future?

    • In any case add doxygen doc for ICCTag and CCTag as they are the entry points
  • use an enum for cctag status:

namespace status
{
// List of possible status
static const int id_reliable = 1;
static const int too_few_outer_points = -1;
static const int no_collected_cuts = -1;     // these two have the same error, is it meant to be like this?
static const int no_selected_cuts = -2;
static const int opti_has_diverged = -3;
static const int id_not_reliable = -4;
static const int degenerate = -5;
}

Switch to

enum class CCTagStatus
{
// List of possible status
     id_reliable = 1,
     too_few_outer_points = -1,
     no_collected_cuts = -1,
     no_selected_cuts = -2,
     opti_has_diverged = -3,
     id_not_reliable = -4,
     degenerate = -5
};

and declare _status as CCTagStatus

Clone this wiki locally