[Utils] getTimeStr: Round up the number of minutes correctly
#2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent getting strings like "5m60s" when rounding up.
fcastan
force-pushed
the
fix/elapsedTimeStr
branch
from
36844a3
to
7abbb50
Compare
fabiencastan
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting times such as 359.5, the previous version of
getTimeStrwas returning "5m60s" instead of "6m0s" because the number of minutes was first computed, and the remaining seconds were rounded up and used as such. In some cases, rounding up those remaining seconds may lead to a full minute, which should be handled.After minutes have been computed, we now check that the rounded up remainder does not correspond to a full minute before moving to the seconds.