-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] Compare various descriptors #115
Conversation
a0dbbad
to
71d4ab7
Compare
@simogasp Is there any way of telling CodeFactor to check again after fixing the complaints? It keeps pointing me at a line where a very long function started when this PR was first created. |
@griwodz there is a re-run link in https://github.com/alicevision/popsift/pull/115/checks |
@simogasp Right now the checks have passed and I do probably not see any re-run links because of that. But I'm sure that I saw it before and pressing it didn't do the right thing. The error kept returning, still reporting a missing null-pointer check from a much earlier commit. Is it possible that there is a processing queue and the new commit were not really checked? |
490ea75
to
8090688
Compare
CMakeLists.txt
Outdated
@@ -34,6 +34,9 @@ else() | |||
message(STATUS "Building in ${CMAKE_BUILD_TYPE} configuration") | |||
endif() | |||
|
|||
include(FindOpenACC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using OpenACC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't. It would simplify the grid filter, but the compiler is not part of the mainstream CUDA SDK yet. It should not be in the PR.
d1383ce
to
cb24f0d
Compare
d74fe40
to
45247e7
Compare
Description
The test script runs VLFeat and PopSift on one or more images and creates the descriptors with orientations.
compareSiftFiles.cpp performs a brute force comparison of the output files and outputs sorted files and some distance computations.
These are then transformed bash and awk and rendered visually with gnuplot.
Features list
Implementation remarks