Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] suppress deprecated cuda sm warnings #124

Merged
merged 1 commit into from
Feb 10, 2021
Merged

[cmake] suppress deprecated cuda sm warnings #124

merged 1 commit into from
Feb 10, 2021

Conversation

simogasp
Copy link
Member

@simogasp simogasp commented Feb 2, 2021

Just added the PopSift_NO_DEPRECATED_CUDA_SM_WARNINGS option to suppress the annoying cuda warnings (as suggested by @griwodz in #113 )

@simogasp simogasp added scope:build cuda issues related to cuda versions labels Feb 2, 2021
@simogasp simogasp added this to the v1.0.0 milestone Feb 2, 2021
@simogasp simogasp requested a review from griwodz February 2, 2021 22:08
@simogasp
Copy link
Member Author

simogasp commented Feb 2, 2021

@griwodz You were right, they are annoying! :-D

@fabiencastan
Copy link
Member

@griwodz Can we merge this PR?

@griwodz
Copy link
Member

griwodz commented Feb 10, 2021

Oh, yes, we should merge this!

griwodz
griwodz approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@griwodz griwodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only a convenience. No danger, but gets rid of lots of warnings for full bilds.

@fabiencastan fabiencastan merged commit 9dd7ae4 into develop Feb 10, 2021
@fabiencastan fabiencastan deleted the cuda/no_deprecated_warnings branch February 10, 2021 19:40
@simogasp simogasp modified the milestones: v1.0.0, v0.9.1 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griwodz griwodz griwodz approved these changes

Assignees
No one assigned
Labels
cuda issues related to cuda versions scope:build
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simogasp @fabiencastan @griwodz