Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/opt ignore threshold #128

Closed
wants to merge 8 commits into from
Closed

Conversation

griwodz
Copy link
Member

@griwodz griwodz commented Feb 14, 2021

Description

In finding extrema, ignore the Edge Threshold and Peak Threshold, when their respective configuration variables are set to 0.0f or less.

Features list

  • Ignoring two checks when the respective config values are 0 or less.
  • Added getDefault functions and usage descriptions to the Config class.

Implementation remarks

@griwodz
Copy link
Member Author

griwodz commented Feb 14, 2021

Codacy complains but I think that it has not run. At least the only issue I can see is not real and seems to belong to an old commit.

@griwodz griwodz self-assigned this Mar 7, 2021
@griwodz griwodz added this to the v1.0.0 milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants