-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CUDA versions through 12.1. #146
Conversation
This failed in the vcpkg build lab; drafted for now:
|
target: sm_87 is the Jetson Orin, @griwodz I don't remember if we skipped that kind of architecture in the past because it was not compiling as well? |
@BillyONeal I think we can remove the 87 architecture as it is not supported for debugging, here is the old discussion I was referring to If that works, we can accept this PR and make a 0.9.1 release that contains this and the other patch you added in vcpkg about the missing headers. That is actually already merged in the develop branch through #144 . Like that, you can avoid patches on vcpkg |
cmake/ChooseCudaCC.cmake
Outdated
elseif(CUDA_VERSION VERSION_GREATER_EQUAL 11.8) | ||
set(CUDA_MIN_CC 35) | ||
set(CUDA_MAX_CC 90) | ||
elseif(CUDA_VERSION VERSION_GREATER_EQUAL 11.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to this https://en.wikipedia.org/wiki/CUDA#GPUs_supported it was since 11.5 (but it's Wikipedia, so I don't know how reliable it is ;-) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.nvidia.com/cuda/archive/11.5.0/cuda-c-programming-guide/index.html#compute-capabilities <-- I extracted all these values by looking at Table 15 here, which doesn't list an 8.7 until 11.6. But if 8.7 was a specific Jetson board or whatever I guess that could make sense.
Of course, the 87 probably has to die anyway given other discussion here...
I'll fix up our patch to validate that it's actually fixed and update this PR with that once it's so. Then we can take an update to your official copy which will drop the patch. |
OK dropping 87 passed in our lab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! |
Description
CUDA 12 dropped support for hardware level 3.5.
I filled out values for all the CUDA versions based on when the hardware level appears in the table at: